librpc/dcesrv_core: assert that dcesrv_call_dispatch_local() never gets async.
authorStefan Metzmacher <metze@samba.org>
Fri, 23 Oct 2020 09:54:29 +0000 (11:54 +0200)
committerSamuel Cabrero <scabrero@sn-devel-184>
Fri, 23 Oct 2020 16:02:37 +0000 (16:02 +0000)
This is just not supported for now...

We would need a dcesrv_call_dispatch_local_send/recv in order to
support async calls.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14551

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Samuel Cabrero <scabrero@samba.org>
librpc/rpc/dcesrv_core.c

index 783d75d5bfe3e84aebd3d3e3bba9371d0fa61cd2..35d7947f438a4ad4dcc8d6fc2be0af53c3fb1d50 100644 (file)
@@ -3008,6 +3008,9 @@ _PUBLIC_ NTSTATUS dcesrv_call_dispatch_local(struct dcesrv_call_state *call)
                return dcerpc_fault_to_nt_status(call->fault_code);
        }
 
+       /* This can never go async for now! */
+       SMB_ASSERT(!(call->state_flags & DCESRV_CALL_STATE_FLAG_ASYNC));
+
        push = ndr_push_init_ctx(call);
        if (push == NULL) {
                return NT_STATUS_NO_MEMORY;