block/blk-map: Remove redundant assignment
authorMichal Orzel <michalorzel.eng@gmail.com>
Sat, 23 Apr 2022 11:38:08 +0000 (13:38 +0200)
committerJens Axboe <axboe@kernel.dk>
Sat, 23 Apr 2022 13:15:26 +0000 (07:15 -0600)
Get rid of redundant assignment to a variable ret from function
bio_map_user_iov as it is being assigned a value that is never read.
It is being re-assigned in the first instruction after the while loop

Reported by clang-tidy [deadcode.DeadStores]

Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
Link: https://lore.kernel.org/r/20220423113811.13335-2-michalorzel.eng@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-map.c

index 7ffde64f90195c9f74873a9b4c8f5f735e714873..df8b066cd548913ca6455d81fee594d2feeed69c 100644 (file)
@@ -262,10 +262,9 @@ static int bio_map_user_iov(struct request *rq, struct iov_iter *iter,
 
                npages = DIV_ROUND_UP(offs + bytes, PAGE_SIZE);
 
-               if (unlikely(offs & queue_dma_alignment(rq->q))) {
-                       ret = -EINVAL;
+               if (unlikely(offs & queue_dma_alignment(rq->q)))
                        j = 0;
-               else {
+               else {
                        for (j = 0; j < npages; j++) {
                                struct page *page = pages[j];
                                unsigned int n = PAGE_SIZE - offs;