KCC: A woeful warning comment about the state of our code

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/source4/scripting/bin/samba_kcc b/source4/scripting/bin/samba_kcc
index 3a2c48871c49af804203f61d8b307b749750790d..f39bee00bc8d498e56e2d0128b8463c851c02963 100755 (executable)
--- a/source4/scripting/bin/samba_kcc
+++ b/source4/scripting/bin/samba_kcc
@@ -750,6 +750,8 @@ class KCC(object):
                     t_repsFrom.dns_name2 = nastr
 
         else:
+            # XXX This entire branch is NEVER used! Because we don't do SMTP!
+            # (see the if condition above). Just close your eyes here.
             if ((t_repsFrom.replica_flags &
                  drsuapi.DRSUAPI_DRS_MAIL_REP) == 0x0):
                 t_repsFrom.replica_flags |= drsuapi.DRSUAPI_DRS_MAIL_REP