mac80211: minstrel_ht: set default tx aggregation timeout to 0
authorFelix Fietkau <nbd@openwrt.org>
Thu, 18 Feb 2016 18:49:18 +0000 (19:49 +0100)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 23 Feb 2016 09:39:24 +0000 (10:39 +0100)
The value 5000 was put here with the addition of the timeout field to
ieee80211_start_tx_ba_session. It was originally added in mac80211 to
save resources for drivers like iwlwifi, which only supports a limited
number of concurrent aggregation sessions.

Since iwlwifi does not use minstrel_ht and other drivers don't need
this, 0 is a better default - especially since there have been
recent reports of aggregation setup related issues reproduced with
ath9k. This should improve stability without causing any adverse
effects.

Cc: stable@vger.kernel.org
Acked-by: Avery Pennarun <apenwarr@gmail.com>
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/rc80211_minstrel_ht.c

index 702328bcabdc2f49b6b2252f304e039ebe37b9af..409b3640da6c92f0505416eb6e9a7334126b5552 100644 (file)
@@ -692,7 +692,7 @@ minstrel_aggr_check(struct ieee80211_sta *pubsta, struct sk_buff *skb)
        if (likely(sta->ampdu_mlme.tid_tx[tid]))
                return;
 
-       ieee80211_start_tx_ba_session(pubsta, tid, 5000);
+       ieee80211_start_tx_ba_session(pubsta, tid, 0);
 }
 
 static void