r17863: Fix unneeded NULL check on pointer parameters causing the

Stanford checker to flag null deref.
Jeremy.
(This used to be commit b7fc023e9025127855fab71002d556e5f84e00b4)

diff --git a/source3/libsmb/clierror.c b/source3/libsmb/clierror.c
index b84a8ee70f841f94fda12864d4f7db3995923b60..44573bd29b1c4c70d9d5ff09aa9338e357ecb432 100644 (file)
--- a/source3/libsmb/clierror.c
+++ b/source3/libsmb/clierror.c
@@ -201,8 +201,6 @@ NTSTATUS cli_nt_error(struct cli_state *cli)
 void cli_dos_error(struct cli_state *cli, uint8 *eclass, uint32 *ecode)
 {
        int  flgs2;
-       char rcls;
-       int code;
 
        if(!cli->initialised) {
                return;
@@ -223,11 +221,8 @@ void cli_dos_error(struct cli_state *cli, uint8 *eclass, uint32 *ecode)
                 return;
         }
 
-       rcls  = CVAL(cli->inbuf,smb_rcls);
-       code  = SVAL(cli->inbuf,smb_err);
-
-       if (eclass) *eclass = rcls;
-       if (ecode) *ecode    = code;
+       *eclass  = CVAL(cli->inbuf,smb_rcls);
+       *ecode  = SVAL(cli->inbuf,smb_err);
 }
 
 /* Return a UNIX errno from a NT status code */