vmlfb: Fix error handling in cr_pll_init()
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Tue, 4 Jul 2017 15:47:23 +0000 (17:47 +0200)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tue, 4 Jul 2017 15:47:23 +0000 (17:47 +0200)
There is an error path, where iomemory is left mapped.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Alan Hourihane <alanh@fairlite.demon.co.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/vermilion/cr_pll.c

index ebc6e6e0dd0f4241f8c0bdba838ffe8f98265f1a..ba105c876bed5c08c731036009751e278a8bab2d 100644 (file)
@@ -185,6 +185,7 @@ static int __init cr_pll_init(void)
        if (err) {
                printk(KERN_ERR
                       "Carillo Ranch failed to initialize vml_sys.\n");
+               iounmap(mch_regs_base);
                pci_dev_put(mch_dev);
                return err;
        }