r4309: idl and torture test for lsa_GetUserName()

why does samba3 return domain_name as in the unknown_name field in the code
and on the wire it returns DCERPC_FAULT_OP_RNG_ERROR?

all of my test machines NT4,W2K,W2K3,XP returned NULL

and if I file the string in the .in.* the server echos the strings back
and returns NT_STATUS_INVALID_PARAMETER

metze

diff --git a/source/librpc/idl/lsa.idl b/source/librpc/idl/lsa.idl
index 5928f44d321b021aa20b31d504675785e501dfc1..ec694df1bf772a437f363c4f1a873e19e27659b4 100644 (file)
--- a/source/librpc/idl/lsa.idl
+++ b/source/librpc/idl/lsa.idl
@@ -649,9 +649,17 @@
                [out,ref] policy_handle *handle
                );
 
+       /**********************/
+       /* Function:     0x2d */
+       typedef struct {
+               lsa_String *string;
+       } lsa_StringPointer;
 
-       /* Function:    0x2d */
-       NTSTATUS lsa_GetUserName();
+       NTSTATUS lsa_GetUserName(
+               [in] unistr *system_name,
+               [in,out] lsa_String *account_name,
+               [in,out] lsa_StringPointer *unknown_name
+               );
 
        /**********************/
        /* Function:          0x2e */

diff --git a/source/torture/rpc/lsa.c b/source/torture/rpc/lsa.c
index fd672699772eb7ac66356eb58359efe99f696208..39d433a791e1d5c45b316538361b3aa05dd4d958 100644 (file)
--- a/source/torture/rpc/lsa.c
+++ b/source/torture/rpc/lsa.c
@@ -1138,6 +1138,29 @@ static BOOL test_QueryInfoPolicy2(struct dcerpc_pipe *p,
        return ret;
 }
 
+static BOOL test_GetUserName(struct dcerpc_pipe *p, 
+                                 TALLOC_CTX *mem_ctx, 
+                                 struct policy_handle *handle)
+{
+       struct lsa_GetUserName r;
+       NTSTATUS status;
+       BOOL ret = True;
+       printf("\nTesting GetUserName\n");
+
+       r.in.system_name = "\\";        
+       r.in.account_name = NULL;       
+       r.in.unknown_name = NULL;
+
+       status = dcerpc_lsa_GetUserName(p, mem_ctx, &r);
+
+       if (!NT_STATUS_IS_OK(status)) {
+               printf("GetUserName failed - %s\n", nt_errstr(status));
+               ret = False;
+       }
+
+       return ret;
+}
+
 static BOOL test_Close(struct dcerpc_pipe *p, 
                       TALLOC_CTX *mem_ctx, 
                       struct policy_handle *handle)
@@ -1230,7 +1253,11 @@ BOOL torture_rpc_lsa(void)
        if (!test_QueryInfoPolicy2(p, mem_ctx, &handle)) {
                ret = False;
        }
-       
+
+       if (!test_GetUserName(p, mem_ctx, &handle)) {
+               ret = False;
+       }
+
 #if 0
        if (!test_Delete(p, mem_ctx, &handle)) {
                ret = False;