ctdb: Fix 1125553 Buffer not null terminated
authorVolker Lendecke <vl@samba.org>
Sat, 7 Mar 2015 10:29:21 +0000 (10:29 +0000)
committerVolker Lendecke <vl@samba.org>
Tue, 10 Mar 2015 20:48:03 +0000 (21:48 +0100)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
ctdb/common/system_linux.c

index 97a57ac8b6596c47414185472defb13e9446e044..fdb8d1275799985a3a9aec30e559411f7876155b 100644 (file)
@@ -100,7 +100,7 @@ int ctdb_sys_send_arp(const ctdb_sock_addr *addr, const char *iface)
                }
 
                DEBUG(DEBUG_DEBUG, (__location__ " Created SOCKET FD:%d for sending arp\n", s));
-               strncpy(ifr.ifr_name, iface, sizeof(ifr.ifr_name)-1);
+               strlcpy(ifr.ifr_name, iface, sizeof(ifr.ifr_name));
                if (ioctl(s, SIOCGIFINDEX, &ifr) < 0) {
                        DEBUG(DEBUG_CRIT,(__location__ " interface '%s' not found\n", iface));
                        close(s);