clk: mvebu: armada-37xx-periph: Fix wrong return value in get_parent
authorGregory CLEMENT <gregory.clement@bootlin.com>
Fri, 13 Jul 2018 10:27:26 +0000 (12:27 +0200)
committerStephen Boyd <sboyd@kernel.org>
Wed, 25 Jul 2018 16:42:50 +0000 (09:42 -0700)
The return value of the get_parent operation is a u8, whereas a -EINVAL
was returned. This wrong value was return if the value was bigger that
the number of parent but this case was already handled by the core.

So we can just remove this chunk of code to fix the issue.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 9818a7a4fd10 ("clk: mvebu: armada-37xx-periph: prepare cpu clk to
be used with DVFS")
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/mvebu/armada-37xx-periph.c

index 6860bd5a37c5e50e9be9e26c40981dea33d57dfc..5cf0a52b87e8a6e94ddebb1852455ba4116a5469 100644 (file)
@@ -428,9 +428,6 @@ static u8 clk_pm_cpu_get_parent(struct clk_hw *hw)
                val &= pm_cpu->mask_mux;
        }
 
-       if (val >= num_parents)
-               return -EINVAL;
-
        return val;
 }