[POWERPC] Sky Cpu and Nexus: check for create_proc_entry ret code
authorCyrill Gorcunov <gorcunov@gmail.com>
Tue, 2 Oct 2007 20:30:07 +0000 (13:30 -0700)
committerPaul Mackerras <paulus@samba.org>
Wed, 3 Oct 2007 02:02:44 +0000 (12:02 +1000)
Adds checking of create_proc_entry call to prevent possible NULL
pointer usage.

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Kumar Gala <galak@gate.crashing.org>
Cc: Brian Waite <waite@skycomputers.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
drivers/misc/hdpuftrs/hdpu_nexus.c

index 01bc9179603be92e39afdb3473225a46e172afd6..cc818532c7ec4b0d1d573250ef7b15d9fa8f0aa7 100644 (file)
@@ -78,10 +78,20 @@ static int hdpu_nexus_probe(struct platform_device *pdev)
        }
 
        hdpu_slot_id = create_proc_entry("sky_slot_id", 0666, &proc_root);
-       hdpu_slot_id->read_proc = hdpu_slot_id_read;
+       if (!hdpu_slot_id) {
+               printk(KERN_WARNING "sky_nexus: "
+                      "Unable to create proc dir entry: sky_slot_id\n");
+       } else {
+               hdpu_slot_id->read_proc = hdpu_slot_id_read;
+       }
 
        hdpu_chassis_id = create_proc_entry("sky_chassis_id", 0666, &proc_root);
-       hdpu_chassis_id->read_proc = hdpu_chassis_id_read;
+       if (!hdpu_chassis_id) {
+               printk(KERN_WARNING "sky_nexus: "
+                      "Unable to create proc dir entry: sky_chassis_id\n");
+       } else {
+               hdpu_chassis_id->read_proc = hdpu_chassis_id_read;
+       }
 
        return 0;
 }