mm/damon/core: initialize damo_filter->list from damos_new_filter()
authorSeongJae Park <sj@kernel.org>
Sat, 29 Jul 2023 20:37:32 +0000 (20:37 +0000)
committerAndrew Morton <akpm@linux-foundation.org>
Fri, 4 Aug 2023 20:03:43 +0000 (13:03 -0700)
damos_new_filter() is not initializing the list field of newly allocated
filter object.  However, DAMON sysfs interface and DAMON_RECLAIM are not
initializing it after calling damos_new_filter().  As a result, accessing
uninitialized memory is possible.  Actually, adding multiple DAMOS filters
via DAMON sysfs interface caused NULL pointer dereferencing.  Initialize
the field just after the allocation from damos_new_filter().

Link: https://lkml.kernel.org/r/20230729203733.38949-2-sj@kernel.org
Fixes: 98def236f63c ("mm/damon/core: implement damos filter")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/core.c

index 91cff7f2997efec5c0108c17f6864cd907db447a..eb9580942a5c320298fb1c49efc3173b61f766d7 100644 (file)
@@ -273,6 +273,7 @@ struct damos_filter *damos_new_filter(enum damos_filter_type type,
                return NULL;
        filter->type = type;
        filter->matching = matching;
+       INIT_LIST_HEAD(&filter->list);
        return filter;
 }