make sure we don't allow the creation of directories containing

wildcard characters. I've only put this in mkdir at the moment, but I
suspect this will apply to all places that can create new filenames.

We need to allow the opening of existing filenames that contain
wildcards, but not allow the creation of new ones.
(This used to be commit 2fd5569938b8970f3e9d761eecad5bc0b8bb267e)

diff --git a/source3/smbd/reply.c b/source3/smbd/reply.c
index 44633b1db6e0c2644fa5025dfa7b0ee111d51ba0..5f3d6fa10e87f937c7b408e6e0d7e94203fc4f63 100644 (file)
--- a/source3/smbd/reply.c
+++ b/source3/smbd/reply.c
@@ -2836,7 +2836,11 @@ NTSTATUS mkdir_internal(connection_struct *conn, pstring directory)
        int ret= -1;
        
        unix_convert(directory,conn,0,&bad_path,&sbuf);
-       
+
+       if (ms_has_wild(directory)) {
+               return NT_STATUS_OBJECT_NAME_INVALID;
+       }
+
        if (check_name(directory, conn))
                ret = vfs_MkDir(conn,directory,unix_mode(conn,aDIR,directory));