s3-rpcclient: pure cosmetics for cmd_spoolss_getprinter.
authorGünther Deschner <gd@samba.org>
Wed, 11 Mar 2009 10:52:04 +0000 (11:52 +0100)
committerGünther Deschner <gd@samba.org>
Fri, 13 Mar 2009 08:25:25 +0000 (09:25 +0100)
Guenther

source3/rpcclient/cmd_spoolss.c

index 1b8588ac48f6894e04a6e8146b80fdfa6ccb8488..e7807e37013637ec933c0f801a2ff44ca1130953 100644 (file)
@@ -567,7 +567,7 @@ static WERROR cmd_spoolss_getprinter(struct rpc_pipe_client *cli,
 {
        POLICY_HND      pol;
        WERROR          result;
-       uint32          info_level = 1;
+       uint32_t        level = 1;
        const char      *printername;
        union spoolss_PrinterInfo info;
 
@@ -578,7 +578,7 @@ static WERROR cmd_spoolss_getprinter(struct rpc_pipe_client *cli,
 
        /* Open a printer handle */
        if (argc == 3) {
-               info_level = atoi(argv[2]);
+               level = atoi(argv[2]);
        }
 
        RPCCLIENT_PRINTERNAME(printername, cli, argv[1]);
@@ -589,21 +589,23 @@ static WERROR cmd_spoolss_getprinter(struct rpc_pipe_client *cli,
                                               printername,
                                               SEC_FLAG_MAXIMUM_ALLOWED,
                                               &pol);
-       if (!W_ERROR_IS_OK(result))
+       if (!W_ERROR_IS_OK(result)) {
                goto done;
+       }
 
        /* Get printer info */
 
        result = rpccli_spoolss_getprinter(cli, mem_ctx,
                                           &pol,
-                                          info_level,
+                                          level,
                                           0,
                                           &info);
-       if (!W_ERROR_IS_OK(result))
+       if (!W_ERROR_IS_OK(result)) {
                goto done;
+       }
 
        /* Display printer info */
-       switch (info_level) {
+       switch (level) {
        case 0:
                display_print_info0(&info.info0);
                break;
@@ -620,12 +622,13 @@ static WERROR cmd_spoolss_getprinter(struct rpc_pipe_client *cli,
                display_print_info7(&info.info7);
                break;
        default:
-               printf("unknown info level %d\n", info_level);
+               printf("unknown info level %d\n", level);
                break;
        }
  done:
-       if (is_valid_policy_hnd(&pol))
+       if (is_valid_policy_hnd(&pol)) {
                rpccli_spoolss_ClosePrinter(cli, mem_ctx, &pol, NULL);
+       }
 
        return result;
 }