libwbclient: Remove a pointless talloc_strdup
authorVolker Lendecke <vl@samba.org>
Sat, 23 Jan 2010 18:26:51 +0000 (19:26 +0100)
committerVolker Lendecke <vl@samba.org>
Sun, 24 Jan 2010 13:52:33 +0000 (14:52 +0100)
nsswitch/libwbclient/wbclient.c

index 9a1e770690e736c78d746c6a153b296c04a1c602..b521567c9094341a2ee5d89286269fafdfaf1894 100644 (file)
@@ -137,24 +137,17 @@ void wbcFreeMemory(void *p)
 
 wbcErr wbcLibraryDetails(struct wbcLibraryDetails **_details)
 {
-       wbcErr wbc_status = WBC_ERR_UNKNOWN_FAILURE;
        struct wbcLibraryDetails *info;
 
        info = talloc(NULL, struct wbcLibraryDetails);
-       BAIL_ON_PTR_ERROR(info, wbc_status);
+       if (info == NULL) {
+               return WBC_ERR_NO_MEMORY;
+       }
 
        info->major_version = WBCLIENT_MAJOR_VERSION;
        info->minor_version = WBCLIENT_MINOR_VERSION;
-       info->vendor_version = talloc_strdup(info,
-                                            WBCLIENT_VENDOR_VERSION);
-       BAIL_ON_PTR_ERROR(info->vendor_version, wbc_status);
+       info->vendor_version = WBCLIENT_VENDOR_VERSION;
 
        *_details = info;
-       info = NULL;
-
-       wbc_status = WBC_ERR_SUCCESS;
-
-done:
-       talloc_free(info);
-       return wbc_status;
+       return WBC_ERR_SUCCESS;
 }