r19330: Fix memleaks
authorSimo Sorce <idra@samba.org>
Mon, 16 Oct 2006 11:57:44 +0000 (11:57 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 19:21:10 +0000 (14:21 -0500)
(This used to be commit f163f422e3f201d8b0e22538949eccf0f7e62143)

source4/dsdb/samdb/ldb_modules/samldb.c

index f6070d518c003924ca8e3b0377add984b7544ef7..f589ba859dfec37b3d6d43e3791bed1ec27aea11 100644 (file)
@@ -130,7 +130,6 @@ static int samldb_find_next_rid(struct ldb_module *module, TALLOC_CTX *mem_ctx,
        if (ret != LDB_SUCCESS) {
                return ret;
        }
-       talloc_steal(mem_ctx, res);
        if (res->count != 1) {
                talloc_free(res);
                return LDB_ERR_OPERATIONS_ERROR;
@@ -257,6 +256,7 @@ static int samldb_get_new_sid(struct ldb_module *module,
                ldb_asprintf_errstring(module->ldb,
                                        "samldb_get_new_sid: error retrieving domain sid from %s: not found!\n",
                                        ldb_dn_linearize(mem_ctx, dom_dn));
+               talloc_free(res);
                return LDB_ERR_CONSTRAINT_VIOLATION;
        }