git.samba.org
/
sharpe
/
samba-autobuild
/
.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
a2daa66
)
ctdb-logging: CID 1396883 Dereference null return value (NULL_RETURNS)
author
Martin Schwenke
<martin@meltin.net>
Thu, 23 Feb 2017 00:31:32 +0000
(11:31 +1100)
committer
Martin Schwenke
<martins@samba.org>
Fri, 24 Feb 2017 06:47:09 +0000
(07:47 +0100)
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12592
The fix in
08e03fa7f5fdc7f988fbbb26929e8c5727f36c2e
is incomplete.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
ctdb/common/logging.c
patch
|
blob
|
history
diff --git
a/ctdb/common/logging.c
b/ctdb/common/logging.c
index c8ccf26b565dd1d89cc5935453e68acbf8f934cb..8e547c97d9d553fa7d43dcb893bc3cc3b3970691 100644
(file)
--- a/
ctdb/common/logging.c
+++ b/
ctdb/common/logging.c
@@
-522,6
+522,7
@@
int logging_init(TALLOC_CTX *mem_ctx, const char *logging,
name = strtok(str, ":");
if (name == NULL) {
+ talloc_free(str);
return EINVAL;
}
option = strtok(NULL, ":");