Revert "s3: VFS: vfs_default. Pass in struct vfswrap_pread_state as the callback...
authorJeremy Allison <jra@samba.org>
Fri, 13 Mar 2020 17:40:33 +0000 (10:40 -0700)
committerJeremy Allison <jra@samba.org>
Wed, 18 Mar 2020 18:03:31 +0000 (18:03 +0000)
This reverts commit e102908f112866d657b8c0cd6a5b217d070210c8.

Now we wait for all aio to finish on all SHUTDOWN_CLOSE
cases, this is no longer needed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14301

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
source3/modules/vfs_default.c

index b8c36180b7c137b034343199b0c1c93d30907a44..4bb4adf5f7e4642d835f9dae8acf2b9a9f4d6d1c 100644 (file)
@@ -827,7 +827,7 @@ static struct tevent_req *vfswrap_pread_send(struct vfs_handle_struct *handle,
        if (tevent_req_nomem(subreq, req)) {
                return tevent_req_post(req, ev);
        }
-       tevent_req_set_callback(subreq, vfs_pread_done, state);
+       tevent_req_set_callback(subreq, vfs_pread_done, req);
 
        talloc_set_destructor(state, vfs_pread_state_destructor);
 
@@ -868,9 +868,10 @@ static int vfs_pread_state_destructor(struct vfswrap_pread_state *state)
 
 static void vfs_pread_done(struct tevent_req *subreq)
 {
-       struct vfswrap_pread_state *state = tevent_req_callback_data(
-               subreq, struct vfswrap_pread_state);
-       struct tevent_req *req = state->req;
+       struct tevent_req *req = tevent_req_callback_data(
+               subreq, struct tevent_req);
+       struct vfswrap_pread_state *state = tevent_req_data(
+               req, struct vfswrap_pread_state);
        int ret;
 
        ret = pthreadpool_tevent_job_recv(subreq);