rpmsg: glink: correctly annotate intent members
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Mon, 18 Jun 2018 12:33:37 +0000 (13:33 +0100)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 31 Jul 2018 06:21:36 +0000 (23:21 -0700)
As intent structure members are not correctly annotated, leading to below warnings

qcom_glink_native.c:614:16: warning: incorrect type in assignment (different base types)
qcom_glink_native.c:614:16:    expected unsigned short [unsigned] [usertype] id
qcom_glink_native.c:614:16:    got restricted __le16 [usertype] <noident>
qcom_glink_native.c:615:18: warning: incorrect type in assignment (different base types)
qcom_glink_native.c:615:18:    expected unsigned short [unsigned] [usertype] lcid
qcom_glink_native.c:615:18:    got restricted __le16 [usertype] <noident>
qcom_glink_native.c:616:19: warning: incorrect type in assignment (different base types)
qcom_glink_native.c:616:19:    expected unsigned int [unsigned] [usertype] count
qcom_glink_native.c:616:19:    got restricted __le32 [usertype] <noident>
qcom_glink_native.c:617:18: warning: incorrect type in assignment (different base types)
qcom_glink_native.c:617:18:    expected unsigned int [unsigned] [usertype] size
qcom_glink_native.c:617:18:    got restricted __le32 [usertype] <noident>
qcom_glink_native.c:618:18: warning: incorrect type in assignment (different base types)
qcom_glink_native.c:618:18:    expected unsigned int [unsigned] [usertype] liid
qcom_glink_native.c:618:18:    got restricted __le32 [usertype] <noident>

Fix this by correctly annotating them.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/rpmsg/qcom_glink_native.c

index f505f58b797d7b3088e3eb8587cb12bc16304636..e4eb5a1f417aee49c690c904a2136b20879e4fad 100644 (file)
@@ -603,11 +603,11 @@ static int qcom_glink_advertise_intent(struct qcom_glink *glink,
                                       struct glink_core_rx_intent *intent)
 {
        struct command {
-               u16 id;
-               u16 lcid;
-               u32 count;
-               u32 size;
-               u32 liid;
+               __le16 id;
+               __le16 lcid;
+               __le32 count;
+               __le32 size;
+               __le32 liid;
        } __packed;
        struct command cmd;