scsi: megaraid_sas: array overflow in megasas_dump_frame()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 14 Feb 2017 16:38:55 +0000 (19:38 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 16 Feb 2017 02:37:35 +0000 (21:37 -0500)
The "sz" variable is in terms of bytes, but we're treating the buffer as
an array of __le32 so we have to divide by 4.

Fixes: def0eab3af86 ("scsi: megaraid_sas: enhance debug logs in OCR context")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/megaraid/megaraid_sas_base.c

index dc9f42e135bbcc345b86f13963c3aeb23f29f7ce..7ac9a9ee9bd473c3cc0b6178975f46e3d32f3b77 100644 (file)
@@ -2754,7 +2754,7 @@ megasas_dump_frame(void *mpi_request, int sz)
        __le32 *mfp = (__le32 *)mpi_request;
 
        printk(KERN_INFO "IO request frame:\n\t");
-       for (i = 0; i < sz; i++) {
+       for (i = 0; i < sz / sizeof(__le32); i++) {
                if (i && ((i % 8) == 0))
                        printk("\n\t");
                printk("%08x ", le32_to_cpu(mfp[i]));