s4:gensec_gssapi: fix CID 1409781: Possible Control flow issues (DEADCODE)
authorStefan Metzmacher <metze@samba.org>
Tue, 23 May 2017 13:05:25 +0000 (15:05 +0200)
committerStefan Metzmacher <metze@samba.org>
Fri, 16 Jun 2017 17:34:17 +0000 (19:34 +0200)
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
source4/auth/gensec/gensec_gssapi.c

index 8bc5452f3b9ce3b468c4fb2b09a424cc00fa3b98..a61b2b2659cbd4001e2acfd4afdccf4999d15fa3 100644 (file)
@@ -457,10 +457,11 @@ static NTSTATUS gensec_gssapi_update_internal(struct gensec_security *gensec_sec
                switch (gensec_security->gensec_role) {
                case GENSEC_CLIENT:
                {
-                       bool fallback = false;
 #ifdef SAMBA4_USES_HEIMDAL
                        struct gsskrb5_send_to_kdc send_to_kdc;
                        krb5_error_code ret;
+#else
+                       bool fallback = false;
 #endif
 
                        nt_status = gensec_gssapi_client_creds(gensec_security, ev);
@@ -581,10 +582,12 @@ static NTSTATUS gensec_gssapi_update_internal(struct gensec_security *gensec_sec
                                        return NT_STATUS_NO_MEMORY;
                                }
 
+#ifndef SAMBA4_USES_HEIMDAL
                                if (fallback &&
                                    strequal(client_realm, server_realm)) {
                                        goto init_sec_context_done;
                                }
+#endif /* !SAMBA4_USES_HEIMDAL */
 
                                nt_status = gensec_gssapi_setup_server_principal(gensec_gssapi_state,
                                                                                 target_principal,