ndrdump: Fix new "struct" feature

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14191

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Pair-progammed-with: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

diff --git a/librpc/tools/ndrdump.c b/librpc/tools/ndrdump.c
index a8f1969a2d401a2acd0cb267ef44ed83d74e87c1..c18531c9b1e96edc8c5ffcc996f370ba402fe301 100644 (file)
--- a/librpc/tools/ndrdump.c
+++ b/librpc/tools/ndrdump.c
@@ -375,7 +375,7 @@ static void ndr_print_dummy(struct ndr_print *ndr, const char *format, ...)
        }
 
        if (strcmp(type, "struct") == 0) {
-               flags = 0; /* neither NDR_IN nor NDR_OUT */
+               flags = NDR_SCALARS|NDR_BUFFERS; /* neither NDR_IN nor NDR_OUT */
                f = find_struct(p, format, &f_buffer);
        } else {
                f = find_function(p, format);

diff --git a/selftest/knownfail.d/ndrdump b/selftest/knownfail.d/ndrdump
deleted file mode 100644 (file)
index 6ad82d7..0000000
--- a/selftest/knownfail.d/ndrdump
+++ /dev/null
@@ -1,2 +0,0 @@
-^samba.tests.blackbox.ndrdump.samba.tests.blackbox.ndrdump.NdrDumpTests.test_ndrdump_with_binary_struct_name
-^samba.tests.blackbox.ndrdump.samba.tests.blackbox.ndrdump.NdrDumpTests.test_ndrdump_with_hex_struct_name