soc: qcom: Fix a IS_ERR() vs NULL bug in probe
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 6 Jun 2023 08:21:22 +0000 (11:21 +0300)
committerBjorn Andersson <andersson@kernel.org>
Tue, 13 Jun 2023 18:57:26 +0000 (11:57 -0700)
The devm_ioremap() function returns NULL on error, it never returns
error pointers.

Fixes: a77b2a0b1280 ("soc: qcom: Introduce RPM master stats driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/ZH7sgpLAN23bCz9v@moroto
drivers/soc/qcom/rpm_master_stats.c

index 6dd98b9f7129e262155a4ba6914593bcf26fcd0c..9ca13bcf67d3c047460752b029727b80b307b670 100644 (file)
@@ -105,7 +105,7 @@ static int master_stats_probe(struct platform_device *pdev)
                }
 
                data[i].base = devm_ioremap(dev, res.start, resource_size(&res));
-               if (IS_ERR(data[i].base)) {
+               if (!data[i].base) {
                        debugfs_remove_recursive(root);
                        return dev_err_probe(dev, -EINVAL,
                                             "Could not map the MSG RAM slice idx %d!\n", i);