kselftest/arm64: Allow larger buffers in get_signal_context()
authorMark Brown <broonie@kernel.org>
Mon, 29 Aug 2022 16:07:02 +0000 (17:07 +0100)
committerCatalin Marinas <catalin.marinas@arm.com>
Wed, 7 Sep 2022 13:25:47 +0000 (14:25 +0100)
In order to allow testing of signal contexts that overflow the base signal
frame allow callers to pass the buffer size for the user context into
get_signal_context(). No functional change.

Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20220829160703.874492-10-broonie@kernel.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
14 files changed:
tools/testing/selftests/arm64/signal/test_signals_utils.h
tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_bad_magic.c
tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_bad_size.c
tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_bad_size_for_magic0.c
tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_duplicated_fpsimd.c
tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_misaligned_sp.c
tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_missing_fpsimd.c
tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_sme_change_vl.c
tools/testing/selftests/arm64/signal/testcases/fake_sigreturn_sve_change_vl.c
tools/testing/selftests/arm64/signal/testcases/sme_vl.c
tools/testing/selftests/arm64/signal/testcases/ssve_regs.c
tools/testing/selftests/arm64/signal/testcases/sve_regs.c
tools/testing/selftests/arm64/signal/testcases/sve_vl.c
tools/testing/selftests/arm64/signal/testcases/za_regs.c

index f3aa99ba67bb7e919929fbbc5c6c87a51d1fcb20..222093f51b6717ce70b406c52b8f22d8f53d7b3f 100644 (file)
@@ -56,7 +56,8 @@ static inline bool feats_ok(struct tdescr *td)
  * at sizeof(ucontext_t).
  */
 static __always_inline bool get_current_context(struct tdescr *td,
-                                               ucontext_t *dest_uc)
+                                               ucontext_t *dest_uc,
+                                               size_t dest_sz)
 {
        static volatile bool seen_already;
 
@@ -64,7 +65,7 @@ static __always_inline bool get_current_context(struct tdescr *td,
        /* it's a genuine invocation..reinit */
        seen_already = 0;
        td->live_uc_valid = 0;
-       td->live_sz = sizeof(*dest_uc);
+       td->live_sz = dest_sz;
        memset(dest_uc, 0x00, td->live_sz);
        td->live_uc = dest_uc;
        /*
index 8dc600a7d4fd1b0fe9eede11e23dee21198069fa..8c7f00ea98237020be929d75f11b9db1394a9283 100644 (file)
@@ -21,7 +21,7 @@ static int fake_sigreturn_bad_magic_run(struct tdescr *td,
        struct _aarch64_ctx *shead = GET_SF_RESV_HEAD(sf), *head;
 
        /* just to fill the ucontext_t with something real */
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        /* need at least 2*HDR_SZ space: KSFT_BAD_MAGIC + terminator. */
index b3c362100666f64d8978eb7efeed7af5d764aa44..1c03f6b638e011dc02f05ebce10adf6be826ce40 100644 (file)
@@ -24,7 +24,7 @@ static int fake_sigreturn_bad_size_run(struct tdescr *td,
        struct _aarch64_ctx *shead = GET_SF_RESV_HEAD(sf), *head;
 
        /* just to fill the ucontext_t with something real */
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        resv_sz = GET_SF_RESV_SIZE(sf);
index a44b88bfc81a8f81c35ac12aded5fb6582a57b1b..bc22f64b544e879648f2bcb613250bb072003d03 100644 (file)
@@ -21,7 +21,7 @@ static int fake_sigreturn_bad_size_for_magic0_run(struct tdescr *td,
        struct _aarch64_ctx *shead = GET_SF_RESV_HEAD(sf), *head;
 
        /* just to fill the ucontext_t with something real */
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        /* at least HDR_SZ for the badly sized terminator. */
index afe8915f0998533106391fdc5d0920188fbda342..63e3906b631c1da9b4613db7a4e42125bde92afd 100644 (file)
@@ -21,7 +21,7 @@ static int fake_sigreturn_duplicated_fpsimd_run(struct tdescr *td,
        struct _aarch64_ctx *shead = GET_SF_RESV_HEAD(sf), *head;
 
        /* just to fill the ucontext_t with something real */
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        head = get_starting_head(shead, sizeof(struct fpsimd_context) + HDR_SZ,
index 1e089e66f9f3c86f20b74ce4684d74ef68cb4416..d00625ff12c238421aab6c0fad7a88af8b8e0c14 100644 (file)
@@ -19,7 +19,7 @@ static int fake_sigreturn_misaligned_run(struct tdescr *td,
                                         siginfo_t *si, ucontext_t *uc)
 {
        /* just to fill the ucontext_t with something real */
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        /* Forcing sigframe on misaligned SP (16 + 3) */
index 08ecd8073a1abc966b63b55c4c88cbb8251b7f61..f805138cb20dd9e7f23c3bccacba0f89b57b1ac4 100644 (file)
@@ -23,7 +23,7 @@ static int fake_sigreturn_missing_fpsimd_run(struct tdescr *td,
        struct _aarch64_ctx *head = GET_SF_RESV_HEAD(sf);
 
        /* just to fill the ucontext_t with something real */
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        resv_sz = GET_SF_RESV_SIZE(sf);
index 7ed762b7202f14dd5e7b55e99d98bc1f37bccd36..ebd5815b54bbaaf883ddeed306260b00180f5b0e 100644 (file)
@@ -54,7 +54,7 @@ static int fake_sigreturn_ssve_change_vl(struct tdescr *td,
        struct sve_context *sve;
 
        /* Get a signal context with a SME ZA frame in it */
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        resv_sz = GET_SF_RESV_SIZE(sf);
index 915821375b0a44bc5209def4c26f8c513cb614a1..e2a452190511ff4ab7e15c084347b5bdb7b967fe 100644 (file)
@@ -56,7 +56,7 @@ static int fake_sigreturn_sve_change_vl(struct tdescr *td,
        struct sve_context *sve;
 
        /* Get a signal context with a SVE frame in it */
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        resv_sz = GET_SF_RESV_SIZE(sf);
index 13ff3b35cbaf578e48325a36b935eb8cdc7533cf..75f387f2db81d9de5b5f59e310e7fb2300d3a3e1 100644 (file)
@@ -34,7 +34,7 @@ static int sme_vl(struct tdescr *td, siginfo_t *si, ucontext_t *uc)
        struct za_context *za;
 
        /* Get a signal context which should have a ZA frame in it */
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        resv_sz = GET_SF_RESV_SIZE(sf);
index 9022a6cab4b33593ccb6cc4a969ee4986f5a5f91..71f14632c524a8f409d8661e2a8ee89447767d13 100644 (file)
@@ -73,7 +73,7 @@ static int do_one_sme_vl(struct tdescr *td, siginfo_t *si, ucontext_t *uc,
         * in it.
         */
        setup_ssve_regs();
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        resv_sz = GET_SF_RESV_SIZE(sf);
index 4b2418aa08a9e76e85282b700fb7100f5f516580..4cdedb7067863d07b3ad8f54784bbbad8ec6c39f 100644 (file)
@@ -71,7 +71,7 @@ static int do_one_sve_vl(struct tdescr *td, siginfo_t *si, ucontext_t *uc,
         * in it.
         */
        setup_sve_regs();
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        resv_sz = GET_SF_RESV_SIZE(sf);
index 92904653add17b246780c0518f9954bff7d83ff6..aa835acec062559fea9455186d594a6c3c38d9f5 100644 (file)
@@ -34,7 +34,7 @@ static int sve_vl(struct tdescr *td, siginfo_t *si, ucontext_t *uc)
        struct sve_context *sve;
 
        /* Get a signal context which should have a SVE frame in it */
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        resv_sz = GET_SF_RESV_SIZE(sf);
index 6f0c1582f5413cbbc8e2b789d9a61ff90773a643..a92b8e9176837de16aafe6ba70c024511cfbbc58 100644 (file)
@@ -73,7 +73,7 @@ static int do_one_sme_vl(struct tdescr *td, siginfo_t *si, ucontext_t *uc,
         * in it.
         */
        setup_za_regs();
-       if (!get_current_context(td, &sf.uc))
+       if (!get_current_context(td, &sf.uc, sizeof(sf.uc)))
                return 1;
 
        resv_sz = GET_SF_RESV_SIZE(sf);