drm/fb-helper: drop redundant pixclock check from drm_fb_helper_set_par()
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 4 Apr 2023 19:40:37 +0000 (21:40 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 5 Apr 2023 20:42:37 +0000 (22:42 +0200)
The fb_check_var hook is supposed to validate all this stuff. Any
errors from fb_set_par are considered driver/hw issues and resulting
in dmesg warnings.

Luckily we do fix up the pixclock already, so this is all fine.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Maxime Ripard <mripard@kernel.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230404194038.472803-2-daniel.vetter@ffwll.ch
drivers/gpu/drm/drm_fb_helper.c

index aa9efc651a1916fa1f501d965b0968a4b0efe29a..d4b4edde5adc7af0ded03f27126f67e84f09a372 100644 (file)
@@ -1641,11 +1641,6 @@ int drm_fb_helper_set_par(struct fb_info *info)
        if (oops_in_progress)
                return -EBUSY;
 
-       if (var->pixclock != 0) {
-               drm_err(fb_helper->dev, "PIXEL CLOCK SET\n");
-               return -EINVAL;
-       }
-
        /*
         * Normally we want to make sure that a kms master takes precedence over
         * fbdev, to avoid fbdev flickering and occasionally stealing the