Actually checking both the account and password tests would be a good idea...

Andrew Bartlett
(This used to be commit 49640635b15f53be6bb28d3d79255abe10c207dd)

diff --git a/source3/auth/auth_sam.c b/source3/auth/auth_sam.c
index 9650dc0940180bf91a1cbe0f27c1ccf340fb12b1..06e27f1d48df25e05fb92d2379e4d503ea79bcaa 100644 (file)
--- a/source3/auth/auth_sam.c
+++ b/source3/auth/auth_sam.c
@@ -420,13 +420,13 @@ static NTSTATUS check_sam_security(const struct auth_context *auth_context,
 
        nt_status = sam_account_ok(mem_ctx, sampass, user_info);
        
-       nt_status = sam_password_ok(auth_context, mem_ctx, sampass, user_info, user_sess_key);
-
        if (!NT_STATUS_IS_OK(nt_status)) {
                pdb_free_sam(&sampass);
                return nt_status;
        }
 
+       nt_status = sam_password_ok(auth_context, mem_ctx, sampass, user_info, user_sess_key);
+
        if (!NT_STATUS_IS_OK(nt_status)) {
                pdb_free_sam(&sampass);
                return nt_status;