r19114: fixed another checker warning and a possible error on allocation

failure
(This used to be commit bc02f7ef96e164a59441e3fd9429221be83fc7e4)

diff --git a/source4/lib/ldb/ldb_tdb/ldb_index.c b/source4/lib/ldb/ldb_tdb/ldb_index.c
index 59c1645ba8ce4593a1e3e6082da51238061bb28a..8a9a82a98ceda39376fe990add14ccd9a677843f 100644 (file)
--- a/source4/lib/ldb/ldb_tdb/ldb_index.c
+++ b/source4/lib/ldb/ldb_tdb/ldb_index.c
@@ -232,13 +232,15 @@ static int ltdb_index_dn_simple(struct ldb_module *module,
 
                list->dn = talloc_array(list, char *, el->num_values);
                if (!list->dn) {
-                       break;          
+                       talloc_free(msg);
+                       return -1;
                }
 
                for (j=0;j<el->num_values;j++) {
                        list->dn[list->count] = 
                                talloc_strdup(list->dn, (char *)el->values[j].data);
                        if (!list->dn[list->count]) {
+                               talloc_free(msg);
                                return -1;
                        }
                        list->count++;