mmc: sdhci: catch all errors when getting regulators
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sat, 14 Oct 2017 19:17:18 +0000 (21:17 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 30 Oct 2017 10:50:37 +0000 (11:50 +0100)
Bail out everytime when mmc_regulator_get_supply() returns an errno, not
only when probing gets deferred. This is currently a no-op, because this
function only returns -EPROBE_DEFER or 0 right now. But if it will throw
another error somewhen, it will be for a reason. (This still doesn't change
that getting regulators is optional, so 0 can still mean no regulators
found). So, let us a) be future proof and b) have driver code which is
easier to understand.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/sdhci.c

index 0d5fcca18c9ec14344d63444a53a39e6f53dde03..1052b52045b190d46813aa6fd83933afc160324a 100644 (file)
@@ -3238,7 +3238,7 @@ int sdhci_setup_host(struct sdhci_host *host)
         * available.
         */
        ret = mmc_regulator_get_supply(mmc);
-       if (ret == -EPROBE_DEFER)
+       if (ret)
                return ret;
 
        DBG("Version:   0x%08x | Present:  0x%08x\n",