libcli: smb2: Never print length if smb2_signing_key_valid() fails for crypto blob.
authorJeremy Allison <jra@samba.org>
Fri, 13 Nov 2020 22:18:43 +0000 (14:18 -0800)
committerVolker Lendecke <vl@samba.org>
Mon, 16 Nov 2020 09:47:38 +0000 (09:47 +0000)
Blob could be NULL.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14210

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Mon Nov 16 09:47:38 UTC 2020 on sn-devel-184

libcli/smb/smb2_signing.c

index 7669b219bbe528a358be54a5fbfb8b0d693039d0..6ece5f2e4d397e6c598b6d9710811eec0b88d530 100644 (file)
@@ -92,8 +92,7 @@ NTSTATUS smb2_signing_sign_pdu(struct smb2_signing_key *signing_key,
        }
 
        if (!smb2_signing_key_valid(signing_key)) {
-               DBG_WARNING("Wrong session key length %zu for SMB2 signing\n",
-                           signing_key->blob.length);
+               DBG_WARNING("No signing key for SMB2 signing\n");
                return NT_STATUS_ACCESS_DENIED;
        }
 
@@ -416,8 +415,7 @@ NTSTATUS smb2_signing_encrypt_pdu(struct smb2_signing_key *encryption_key,
        tf = (uint8_t *)vector[0].iov_base;
 
        if (!smb2_signing_key_valid(encryption_key)) {
-               DBG_WARNING("Wrong encryption key length %zu for SMB2 signing\n",
-                           encryption_key->blob.length);
+               DBG_WARNING("No encryption key for SMB2 signing\n");
                return NT_STATUS_ACCESS_DENIED;
        }
 
@@ -625,8 +623,7 @@ NTSTATUS smb2_signing_decrypt_pdu(struct smb2_signing_key *decryption_key,
        tf = (uint8_t *)vector[0].iov_base;
 
        if (!smb2_signing_key_valid(decryption_key)) {
-               DBG_WARNING("Wrong decryption key length %zu for SMB2 signing\n",
-                           decryption_key->blob.length);
+               DBG_WARNING("No decryption key for SMB2 signing\n");
                return NT_STATUS_ACCESS_DENIED;
        }