Fix a scary "fill_share_mode_lock failed" message
authorVolker Lendecke <vl@samba.org>
Thu, 26 Mar 2009 11:24:50 +0000 (12:24 +0100)
committerKarolin Seeger <kseeger@samba.org>
Fri, 27 Mar 2009 12:06:56 +0000 (13:06 +0100)
To me "fill_share_mode_lock failed" is a "can't happen" alert. There is
however a perfectly valid case in get_file_infos() when the file is not open.

Change the corresponding debug message to level 10 and explain more.
(cherry picked from commit f73d4cf1fcfd8f9e2543a222faed133472fd890c)

source/locking/locking.c

index eebf8701b5070369b4ac21d4288348bdb7290359..b8cd29f8a60e913e02462ec819197a3de8de0ebc 100644 (file)
@@ -854,7 +854,8 @@ struct share_mode_lock *fetch_share_mode_unlocked(TALLOC_CTX *mem_ctx,
        }
 
        if (!fill_share_mode_lock(lck, id, servicepath, fname, data, NULL)) {
-               DEBUG(3, ("fill_share_mode_lock failed\n"));
+               DEBUG(10, ("fetch_share_mode_unlocked: no share_mode record "
+                          "around (file not open)\n"));
                TALLOC_FREE(lck);
                return NULL;
        }