r6737: Explain these error returns a bit better.

Andrew Bartlett
(This used to be commit 77d054c65aeecfc0d1156d750f7b8025cb154d3a)

diff --git a/source4/auth/gensec/gensec_gssapi.c b/source4/auth/gensec/gensec_gssapi.c
index 8ee0c182081dfbc2781dd412db78dceaf19c269c..9809a1b4084a7c3bf58244d9af50050dad8e9ffd 100644 (file)
--- a/source4/auth/gensec/gensec_gssapi.c
+++ b/source4/auth/gensec/gensec_gssapi.c
@@ -96,7 +96,9 @@ static NTSTATUS gensec_gssapi_start(struct gensec_security *gensec_security)
 
        if (gensec_security->want_features & GENSEC_FEATURE_SESSION_KEY) {
 #ifndef HAVE_GSSKRB5_GET_INITIATOR_SUBKEY
-               /* GSSAPI won't give us the session keys, without the right hook */
+               /* GSSAPI won't give us the session keys, without the
+                * right hooks.  This is critical when requested, so
+                * fail outright. */
                return NT_STATUS_INVALID_PARAMETER;
 #endif
        }
@@ -108,7 +110,8 @@ static NTSTATUS gensec_gssapi_start(struct gensec_security *gensec_security)
        }
        if (gensec_security->want_features & GENSEC_FEATURE_DCE_STYLE) {
 #ifndef GSS_C_DCE_STYLE
-               /* GSSAPI won't give us the session keys, without the right hook */
+               /* GSSAPI DCE_STYLE is critical when requested, so
+                * fail outright */
                return NT_STATUS_INVALID_PARAMETER;
 #else
                gensec_gssapi_state->want_flags |= GSS_C_DCE_STYLE;