git.samba.org
/
ira
/
wip.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
cc90415
)
s3: Fix Coverity ID 2288: Uninitialized read
author
Volker Lendecke
<vl@samba.org>
Tue, 15 Mar 2011 09:52:49 +0000
(10:52 +0100)
committer
Volker Lendecke
<vl@samba.org>
Tue, 15 Mar 2011 10:10:43 +0000
(11:10 +0100)
We passed the structure including the uninitialized elements to
dcerpc_winreg_SetValue.
source3/rpc_client/cli_winreg.c
patch
|
blob
|
history
diff --git
a/source3/rpc_client/cli_winreg.c
b/source3/rpc_client/cli_winreg.c
index c3f0c901f8444ebdf8f9f3cdc1734567c22d9c17..cf23c2a676dae798babebb25e44e1cec8127f550 100644
(file)
--- a/
source3/rpc_client/cli_winreg.c
+++ b/
source3/rpc_client/cli_winreg.c
@@
-456,7
+456,7
@@
NTSTATUS dcerpc_winreg_set_expand_sz(TALLOC_CTX *mem_ctx,
const char *data,
WERROR *pwerr)
{
- struct winreg_String wvalue;
+ struct winreg_String wvalue
= { 0, }
;
DATA_BLOB blob;
WERROR result = WERR_OK;
NTSTATUS status;