proc: Reduce cache miss in xfrm_statistics_seq_show
authorJia He <hejianet@gmail.com>
Fri, 30 Sep 2016 03:29:02 +0000 (11:29 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Sep 2016 05:50:45 +0000 (01:50 -0400)
This is to use the generic interfaces snmp_get_cpu_field{,64}_batch to
aggregate the data by going through all the items of each cpu sequentially.

Signed-off-by: Jia He <hejianet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/xfrm/xfrm_proc.c

index 9c4fbd8935f48e28c3c86d9da443904f55f93ec3..ba2b539879bc410645dee8fa2f218e241863ff71 100644 (file)
@@ -50,12 +50,18 @@ static const struct snmp_mib xfrm_mib_list[] = {
 
 static int xfrm_statistics_seq_show(struct seq_file *seq, void *v)
 {
+       unsigned long buff[LINUX_MIB_XFRMMAX];
        struct net *net = seq->private;
        int i;
+
+       memset(buff, 0, sizeof(unsigned long) * LINUX_MIB_XFRMMAX);
+
+       snmp_get_cpu_field_batch(buff, xfrm_mib_list,
+                                net->mib.xfrm_statistics);
        for (i = 0; xfrm_mib_list[i].name; i++)
                seq_printf(seq, "%-24s\t%lu\n", xfrm_mib_list[i].name,
-                          snmp_fold_field(net->mib.xfrm_statistics,
-                                          xfrm_mib_list[i].entry));
+                                               buff[i]);
+
        return 0;
 }