drm/i915: Do not clear mappings beyond VMA size
authorJoonas Lahtinen <joonas.lahtinen@linux.intel.com>
Fri, 24 Apr 2015 12:09:03 +0000 (15:09 +0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 8 May 2015 11:03:19 +0000 (13:03 +0200)
Do not to clear mappings outside the allocated VMA under any
circumstances. Only clear the smaller of VMA or object page count.

This is required to allow creating partial object VMAs which in
turn are needed for partial GGTT views.

Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_gem_gtt.c

index 9d3852c521c753023d8b1b54dddda9568dd28736..fc562c68bf48eb060623b2ba14dce5c9ed1cb054 100644 (file)
@@ -1945,19 +1945,23 @@ static void ggtt_unbind_vma(struct i915_vma *vma)
        struct drm_device *dev = vma->vm->dev;
        struct drm_i915_private *dev_priv = dev->dev_private;
        struct drm_i915_gem_object *obj = vma->obj;
+       const uint64_t size = min_t(uint64_t,
+                                   obj->base.size,
+                                   vma->node.size);
 
        if (vma->bound & GLOBAL_BIND) {
                vma->vm->clear_range(vma->vm,
                                     vma->node.start,
-                                    obj->base.size,
+                                    size,
                                     true);
        }
 
        if (dev_priv->mm.aliasing_ppgtt && vma->bound & LOCAL_BIND) {
                struct i915_hw_ppgtt *appgtt = dev_priv->mm.aliasing_ppgtt;
+
                appgtt->base.clear_range(&appgtt->base,
                                         vma->node.start,
-                                        obj->base.size,
+                                        size,
                                         true);
        }
 }