media: ti-vpe: vpe: use r2y instead of y2r, copy-paste error
authorColin Ian King <colin.king@canonical.com>
Fri, 11 Oct 2019 13:29:40 +0000 (10:29 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 24 Oct 2019 21:32:38 +0000 (18:32 -0300)
There appears to be a copy-paste error on the access of
csc_coeffs.y2r.r601.full.coeff, I believe csc_coeffs.2yr.r601.full.coeff
should be used instead. This is a moot point as the code is never
reached, but at least use the correct structure element.

Addresses-Coverity: ("Copy-paste error")

Fixes: 3ff3a712a9ea ("media: ti-vpe: vpe: don't rely on colorspace member for conversion")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/ti-vpe/csc.c

index bd923bee4a31cf661ccce31febd8478bf00e71ec..834114a4eebe166230d7abc47cd3db26706aa49a 100644 (file)
@@ -238,7 +238,7 @@ void csc_set_coeff(struct csc_data *csc, u32 *csc_reg0,
                                coeff = csc_coeffs.r2y.r709.limited.coeff;
                } else {
                        /* Should never reach this, but it keeps gcc happy */
-                       coeff = csc_coeffs.y2r.r601.full.coeff;
+                       coeff = csc_coeffs.r2y.r601.full.coeff;
                }
        } else {
                *csc_reg5 |= CSC_BYPASS;