be2net: do not modify PCI MaxReadReq size
authorSathya Perla <sathya.perla@emulex.com>
Tue, 5 Jun 2012 19:37:19 +0000 (19:37 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 6 Jun 2012 16:06:18 +0000 (09:06 -0700)
Setting the PCI MRRS to a value of 4096 (overriding the system decided
value) had provided perf improvement in TX.
But, IBM has provided feedback that on POWER platforms, this value is set
by the system firmware, and drivers modifying this value can cause
unpredictable results (like EEH errors.) So, backing off this change.
On POWER7 platforms most slots, it seems, do get a MRRS of 4096.

This patch reverts the following commit:
"be2net: Modified PCI MaxReadReq size to 4096 bytes"
commit 5a56eb10babbcd7b3796dc3c28c271260aa3608d.

Suggested-by: Brian King <bjking1@us.ibm.com>
Signed-off-by: Sathya Perla <sathya.perla@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/emulex/benet/be_main.c

index cfbec8b495cbff5dc6379b54ea732dd3f437acdc..695c3cf76e8ddfd7f659fb5df6b52696e7ae303d 100644 (file)
@@ -2766,8 +2766,6 @@ static int be_setup(struct be_adapter *adapter)
                be_cmd_set_flow_control(adapter, adapter->tx_fc,
                                        adapter->rx_fc);
 
-       pcie_set_readrq(adapter->pdev, 4096);
-
        if (be_physfn(adapter) && num_vfs) {
                if (adapter->dev_num_vfs)
                        be_vf_setup(adapter);