python/gp_cert_auto_enroll: Fix bitwise test in expression

Found by covscan.

result_independent_of_operands: "(e.data & 4) == 1" is always false regardless of the values of its operands. This occurs as the operand of assignment.

Signed-off-by: Pavel Filipenský <pfilipen@redhat.com>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/python/samba/gp_cert_auto_enroll_ext.py b/python/samba/gp_cert_auto_enroll_ext.py
index 680525c9ced46c6f27bc616a71b5b770da047f63..585dc56055035fbe2773f28c0c5b1fcee54653d1 100644 (file)
--- a/python/samba/gp_cert_auto_enroll_ext.py
+++ b/python/samba/gp_cert_auto_enroll_ext.py
@@ -358,9 +358,9 @@ class gp_cert_auto_enroll_ext(gp_pol_ext):
                         # This policy applies as specified in [MS-CAESO] 4.4.5.1
                         if e.data == 0x8000:
                             continue # The policy is disabled
-                        enroll = e.data & 0x1 == 1
-                        manage = e.data & 0x2 == 1
-                        retrive_pending = e.data & 0x4 == 1
+                        enroll = e.data & 0x1 == 0x1
+                        manage = e.data & 0x2 == 0x2
+                        retrive_pending = e.data & 0x4 == 0x4
                         if enroll:
                             self.__enroll(pol_conf.entries, trust_dir,
                                           private_dir)