USB: serial: mos7840: remove set but not used variables 'number, serial'
authorYueHaibing <yuehaibing@huawei.com>
Fri, 7 Dec 2018 02:50:42 +0000 (02:50 +0000)
committerJohan Hovold <johan@kernel.org>
Mon, 10 Dec 2018 09:20:44 +0000 (10:20 +0100)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/usb/serial/mos7840.c: In function 'mos7840_send_cmd_write_baud_rate':
drivers/usb/serial/mos7840.c:1584:16: warning:
 variable 'number' set but not used [-Wunused-but-set-variable]

drivers/usb/serial/mos7840.c: In function 'mos7840_change_port_settings':
drivers/usb/serial/mos7840.c:1695:21: warning:
 variable 'serial' set but not used [-Wunused-but-set-variable]

'number' never used since introduction in commit 3f5429746d91 ("USB: Moschip
7840 USB-Serial Driver")

'serial' not used since commit 5833041f1b13 ("USB: serial: remove unnecessary
reinitialisations of urb->dev")

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/mos7840.c

index 6ff6d67b6d5a83ac01502c8d013bbc6cda048269..a698d46ba773a2c8be6a17be6abb2a7b94f291e9 100644 (file)
@@ -1581,7 +1581,6 @@ static int mos7840_send_cmd_write_baud_rate(struct moschip_port *mos7840_port,
        int divisor = 0;
        int status;
        __u16 Data;
-       unsigned char number;
        __u16 clk_sel_val;
        struct usb_serial_port *port;
 
@@ -1595,8 +1594,6 @@ static int mos7840_send_cmd_write_baud_rate(struct moschip_port *mos7840_port,
        if (mos7840_serial_paranoia_check(port->serial, __func__))
                return -1;
 
-       number = mos7840_port->port->port_number;
-
        dev_dbg(&port->dev, "%s - baud = %d\n", __func__, baudRate);
        /* reset clk_uart_sel in spregOffset */
        if (baudRate > 115200) {
@@ -1692,7 +1689,6 @@ static void mos7840_change_port_settings(struct tty_struct *tty,
        int status;
        __u16 Data;
        struct usb_serial_port *port;
-       struct usb_serial *serial;
 
        if (mos7840_port == NULL)
                return;
@@ -1705,8 +1701,6 @@ static void mos7840_change_port_settings(struct tty_struct *tty,
        if (mos7840_serial_paranoia_check(port->serial, __func__))
                return;
 
-       serial = port->serial;
-
        if (!mos7840_port->open) {
                dev_dbg(&port->dev, "%s - port not opened\n", __func__);
                return;