ext4: Fix truncation of symlinks after failed write
authorJan Kara <jack@suse.cz>
Mon, 13 Jul 2009 20:22:22 +0000 (16:22 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 13 Jul 2009 20:22:22 +0000 (16:22 -0400)
commitffacfa7a79d6c00624196b2d13b0a7f72f2b8227
tree201920b755aff4c8a196006c0ec5538235b7ee32
parentf91d1d04171026e56c7e343ee3cdcc801dd85cfb
ext4: Fix truncation of symlinks after failed write

Contents of long symlinks is written via standard write methods. So
when the write fails, we add inode to orphan list. But symlinks don't
have .truncate method defined so nobody properly removes them from the
on disk orphan list.

Fix this by calling ext4_truncate() directly instead of calling
vmtruncate() (which is saner anyway since we don't need anything
vmtruncate() does except from calling .truncate in these paths).  We
also add inode to orphan list only if ext4_can_truncate() is true
(currently, it can be false for symlinks when there are no blocks
allocated) - otherwise orphan list processing will complain and
ext4_truncate() will not remove inode from on-disk orphan list.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/inode.c