V4L/DVB (13166): remove duplicate structure field initialization
authorJulia Lawall <julia@diku.dk>
Sat, 19 Sep 2009 19:48:17 +0000 (16:48 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 5 Dec 2009 20:40:40 +0000 (18:40 -0200)
commite6a1a08f00689b0006bef2376ac30daa467901e9
tree11d8f8d3b6a2eed0842e8e8f3d4a453d510de015
parent7cbefad085c9112d0b1814db18423e5da072f5c8
V4L/DVB (13166): remove duplicate structure field initialization

The definition of tvaudio_tuner_ops initializes the s_tuner field twice.
It appears that the second case should initialize the g_tuner field.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier I, s, fld;
position p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@s@
identifier I, s, r.fld;
position r.p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@script:python@
p0 << r.p0;
fld << r.fld;
ps << s.p;
pr << r.p;
@@

if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column):
  cocci.print_main(fld,p0)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/tvaudio.c