ASoC: cs35l56: Fix an unsigned comparison which can never be negative
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Fri, 24 Mar 2023 02:23:03 +0000 (10:23 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 24 Mar 2023 12:15:24 +0000 (12:15 +0000)
commitab76c891a687ae871f7e76dbf9bc3a0e32b53423
tree071e21428074cb53648289f183b3e0f5c10ddc4a
parent92405802a7d6aa1953915af869192296d1792d18
ASoC: cs35l56: Fix an unsigned comparison which can never be negative

The variable 'rv' is defined as unsigned type, so the following if
statement is invalid, we can modify the type of rv to int.
if (rv < 0) {
dev_err(cs35l56->dev, "irq: failed to get pm_runtime:
%d\n", rv);
goto err_unlock;
}

./sound/soc/codecs/cs35l56.c:333:5-7: WARNING: Unsigned expression compared with zero: rv < 0.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4599
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230324022303.121485-1-jiapeng.chong@linux.alibaba.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l56.c