drm/selftest: plane_helper: Put test structures in static storage
authorNathan Chancellor <nathan@kernel.org>
Wed, 2 Mar 2022 23:59:09 +0000 (16:59 -0700)
committerMaxime Ripard <maxime@cerno.tech>
Mon, 21 Mar 2022 10:05:05 +0000 (11:05 +0100)
commita860f266a0e19f271b839451d291a6acf6ddcfe8
tree84feabfc8ffb63cb2350c0d8b5eea352deee30c3
parent1d204ee10817aed6666e020ef1b4c643d68bef11
drm/selftest: plane_helper: Put test structures in static storage

Clang warns on certain 32-bit architectures:

  drivers/gpu/drm/selftests/test-drm_plane_helper.c:76:5: warning: stack frame size (1064) exceeds limit (1024) in 'igt_check_plane_state' [-Wframe-larger-than]
  int igt_check_plane_state(void *ignored)
      ^
  1 warning generated.

The structures in igt_check_plane_state() total 1008 bytes, so any small
amount of inlining will cause the stack frame to exceed the 32-bit limit
of 1024, triggering the warning.

Move these structures to static storage, which dramatically reduces the
amount of stack space in igt_check_plane_state(). There is no testing
impact, as igt_check_plane_state() is only called once in the driver.

Fixes: 943e6a8beeac ("mock a drm_plane in igt_check_plane_state to make the test more robust")
Link: https://github.com/ClangBuiltLinux/linux/issues/1600
Reported-by: kernel test robot <lkp@intel.com>
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20220302235909.784935-1-nathan@kernel.org
drivers/gpu/drm/selftests/test-drm_plane_helper.c