media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props()
authorMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 4 Apr 2018 11:21:04 +0000 (07:21 -0400)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 17 Apr 2018 09:49:58 +0000 (05:49 -0400)
commit9879c9d3ecb45379adf180a28a7cea19cdca07bd
treeb7b6a4b05921ebefa9826268afb5dcd6c60a6aac
parent76d81243a487c09619822ef8e7201a756e58a87d
media: v4l2-fwnode: simplify v4l2_fwnode_reference_parse_int_props()

The logic at v4l2_fwnode_reference_parse_int_props() is somewhat
complex and violates Linux coding style, as it does multiple
statements on a single line. That makes static analyzers to
be confused, as warned by smatch:

drivers/media/v4l2-core/v4l2-fwnode.c:832 v4l2_fwnode_reference_parse_int_props() warn: passing zero to 'PTR_ERR'

Simplify the logic, in order to make clearer about what happens
when v4l2_fwnode_reference_get_int_prop() returns an error.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/v4l2-core/v4l2-fwnode.c