cpuidle: Avoid potential overflow in integer multiplication
authorC Cheng <C.Cheng@mediatek.com>
Tue, 19 Dec 2023 03:14:42 +0000 (11:14 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 12 Feb 2024 16:07:49 +0000 (17:07 +0100)
commit88390dd788db485912ee7f9a8d3d56fc5265d52f
treeadab5bec8ae0c99181de60183edcd1ed47046432
parent496d0a648509bce665a85e19a871375dfe4c8f2e
cpuidle: Avoid potential overflow in integer multiplication

In detail:

In C language, when you perform a multiplication operation, if
both operands are of int type, the multiplication operation is
performed on the int type, and then the result is converted to
the target type. This means that if the product of int type
multiplication exceeds the range that int type can represent,
an overflow will occur even if you store the result in a
variable of int64_t type.

For a multiplication of two int values, it is better to use
mul_u32_u32() rather than s->exit_latency_ns = s->exit_latency *
NSEC_PER_USEC to avoid potential overflow happenning.

Signed-off-by: C Cheng <C.Cheng@mediatek.com>
Signed-off-by: Bo Ye <bo.ye@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
[ rjw: New subject ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpuidle/driver.c