Revert "kernfs: fix memleak in kernel_ops_readdir()"
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Aug 2019 06:39:35 +0000 (08:39 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Aug 2019 06:39:35 +0000 (08:39 +0200)
commit8097c43bcbec56fbd0788d99e1e236c0e0d4013f
tree5daf696782d7c8b06de28d035cd896ce222dc708
parentcc798c83898ea0a77fcaa1a92afda35c3c3ded74
Revert "kernfs: fix memleak in kernel_ops_readdir()"

This reverts commit cc798c83898ea0a77fcaa1a92afda35c3c3ded74.

Tony writes:
Somehow this causes a regression in Linux next for me where I'm
seeing lots of sysfs entries now missing under
/sys/bus/platform/devices.

For example, I now only see one .serial entry show up in sysfs.
Things work again if I revert commit cc798c83898e ("kernfs: fix
memleak inkernel_ops_readdir()"). Any ideas why that would be?

Tejun says:
Ugh, you're right.  It can get double-put cuz ctx->pos is put by
release too.

So reverting it for now.

Reported-by: Tony Lindgren <tony@atomide.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Fixes: cc798c83898e ("kernfs: fix memleak in kernel_ops_readdir()")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/kernfs/dir.c