]> git.samba.org - garming/samba-autobuild/.git/commit
r2857: this commit gets rid of smb_ucs2_t, wpstring and fpstring, plus lots of associ...
authorAndrew Tridgell <tridge@samba.org>
Fri, 8 Oct 2004 08:13:00 +0000 (08:13 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 17:59:39 +0000 (12:59 -0500)
commit7d32679e9683c81aca538f0267684332a28a286f
tree445aecfad24e8dab1fe7a200904a712212fa7091
parent48f960ab47707ca24898834da4da440d1f7fb0d9
r2857: this commit gets rid of smb_ucs2_t, wpstring and fpstring, plus lots of associated functions.

The motivation for this change was to avoid having to convert to/from
ucs2 strings for so many operations. Doing that was slow, used many
static buffers, and was also incorrect as it didn't cope properly with
unicode codepoints above 65536 (which could not be represented
correctly as smb_ucs2_t chars)

The two core functions that allowed this change are next_codepoint()
and push_codepoint(). These functions allow you to correctly walk a
arbitrary multi-byte string a character at a time without converting
the whole string to ucs2.

While doing this cleanup I also fixed several ucs2 string handling
bugs. See the commit for details.

The following code (which counts the number of occuraces of 'c' in a
string) shows how to use the new interface:

size_t count_chars(const char *s, char c)
{
size_t count = 0;

while (*s) {
size_t size;
codepoint_t c2 = next_codepoint(s, &size);
if (c2 == c) count++;
s += size;
}

return count;
}
(This used to be commit 814881f0e50019196b3aa9fbe4aeadbb98172040)
24 files changed:
source4/auth/pass_check.c
source4/include/charset.h
source4/include/rewrite.h
source4/include/safe_string.h
source4/lib/basic.mk
source4/lib/charcnv.c
source4/lib/cmdline/popt_common.c
source4/lib/iconv.c
source4/lib/ms_fnmatch.c
source4/lib/registry/reg_backend_nt4/reg_backend_nt4.c
source4/lib/util_str.c
source4/lib/util_strlist.c [new file with mode: 0644]
source4/lib/util_unistr.c
source4/libads/ldap_printer.c
source4/libcli/auth/ntlmssp_parse.c
source4/libcli/raw/rawrequest.c
source4/libcli/util/smbencrypt.c
source4/librpc/ndr/ndr_basic.c
source4/smb_server/request.c
source4/smbd/server.c
source4/torture/basic/utable.c
source4/torture/local/iconv.c
source4/torture/masktest.c
source4/torture/rpc/netlogon.c