ALSA: hdac: fix memory release for SST and SOF drivers
authorAmadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Wed, 22 May 2019 16:21:41 +0000 (11:21 -0500)
committerMark Brown <broonie@kernel.org>
Thu, 6 Jun 2019 16:37:01 +0000 (17:37 +0100)
commit6d647b736a6b1cbf2f8deab0e6a94c34a6ea9d60
tree16436647368b00dd04435ef436d42056b0dbfea4
parent1f5253b08e06bc798e5254ede22d4238e9a52af8
ALSA: hdac: fix memory release for SST and SOF drivers

During the integration of HDaudio support, we changed the way in which
we get hdev in snd_hdac_ext_bus_device_init() to use one preallocated
with devm_kzalloc(), however it still left kfree(hdev) in
snd_hdac_ext_bus_device_exit(). It leads to oopses when trying to
rmmod and modprobe. Fix it, by just removing kfree call.

SOF also uses some of the snd_hdac_ functions for HDAudio support but
allocated the memory with kzalloc. A matching fix is provided
separately to align all users of the snd_hdac_ library.

Fixes: 6298542fa33b ("ALSA: hdac: remove memory allocation from snd_hdac_ext_bus_device_init")
Reviewed-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/hda/ext/hdac_ext_bus.c