r8169: fix broken Wake-on-LAN from S5 (poweroff)
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 25 Oct 2018 16:40:19 +0000 (18:40 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 25 Oct 2018 23:15:23 +0000 (16:15 -0700)
commit649f0837a8cc2b39329f2de00fa0d04b029291c5
tree6806f4fd2348dee5e85de8e06eabc240f48d1701
parent42d0f71c9b5fd48861d61cfc05c9e001f847c9d5
r8169: fix broken Wake-on-LAN from S5 (poweroff)

It was reported that WoL from S5 is broken (WoL from S3 works) and the
analysis showed that during system shutdown the network interface was
brought down already when the actual kernel shutdown started.
Therefore netif_running() returned false and as a consequence the PHY
was suspended. Obviously WoL wasn't working then.
To fix this the original patch needs to be effectively reverted.
A side effect is that when normally bringing down the interface and
WoL is enabled the PHY will remain powered on (like it was before the
original patch).

Fixes: fe87bef01f9b ("r8169: don't check WoL when powering down PHY and interface is down")
Reported-by: Neil MacLeod <neil@nmacleod.com>
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169.c