tty/amiserial: avoid interruptible_sleep_on
authorArnd Bergmann <arnd@arndb.de>
Thu, 2 Jan 2014 12:07:38 +0000 (13:07 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Jan 2014 01:05:21 +0000 (17:05 -0800)
commit591cee0a35632031cd925392a1bce507dcfe9ea8
treedeb6628428c2f3b88f98846f1928658dbf43cb34
parentf8e87cb4a19aa5f5a1ce22e130da0f4a7fa2d5f3
tty/amiserial: avoid interruptible_sleep_on

interruptible_sleep_on is generally problematic and we want to get
rid of it. In case of TIOCMIWAIT, that race is actually in user
space and does not get fixed since we can only detect changes after
entering the ioctl handler, but it removes one more caller.

This instance can not be trivially replaced with wait_event, so
I chose to open-code the wait loop using prepare_to_wait/finish_wait.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/amiserial.c