pidl: set the per-request memory context in the pidl generator
authorRalph Boehme <slow@samba.org>
Tue, 23 Mar 2021 10:40:21 +0000 (11:40 +0100)
committerRalph Boehme <slow@samba.org>
Wed, 31 Mar 2021 11:11:31 +0000 (11:11 +0000)
commit4c3fb2a5912966a61e7ebdb05eb3231a0e1d6033
tree3e59df526c579064bd3f7b086dd4b75ea5593638
parent10d753868e810604d8f60673bbd48f55aaff0797
pidl: set the per-request memory context in the pidl generator

The talloc memory context referenced by the pipe_struct mem_ctx member is used
as talloc parent for RPC response data by the RPC service implementations.

In Samba versions up to 4.10 all talloc children of p->mem_ctx were freed after
a RPC response was delivered by calling talloc_free_children(p->mem_ctx). Commit
60fa8e255254d38e9443bf96f2c0f31430be6ab8 removed this call which resulted in all
memory allocations on this context not getting released, which can consume
significant memory in long running RPC connections.

Instead of putting the talloc_free_children(p->mem_ctx) back, just use the
mem_ctx argument of the ${pipename}_op_dispatch_internal() function which is a
dcesrv_call_state object created by dcesrv_process_ncacn_packet() and released
by the RPC server when the RPC request processing is finished.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14675
CI: https://gitlab.com/samba-team/samba/-/merge_requests/1861

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
pidl/lib/Parse/Pidl/Samba4/NDR/ServerCompat.pm
source3/rpc_server/rpc_handles.c