sched/fair: Fix the update of blocked load when newly idle
authorVincent Guittot <vincent.guittot@linaro.org>
Thu, 26 Apr 2018 10:19:32 +0000 (12:19 +0200)
committerIngo Molnar <mingo@kernel.org>
Thu, 3 May 2018 05:38:03 +0000 (07:38 +0200)
commit457be908c83637ee10bda085a23dc05afa3b14a0
treee578083954eca7d085ad6428ca5ddc140657c40a
parent0b26351b910fb8fe6a056f8a1bbccabe50c0e19f
sched/fair: Fix the update of blocked load when newly idle

With commit:

  31e77c93e432 ("sched/fair: Update blocked load when newly idle")

... we release the rq->lock when updating blocked load of idle CPUs.

This opens a time window during which another CPU can add a task to this
CPU's cfs_rq.

The check for newly added task of idle_balance() is not in the common path.
Move the out label to include this check.

Reported-by: Heiner Kallweit <hkallweit1@gmail.com>
Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 31e77c93e432 ("sched/fair: Update blocked load when newly idle")
Link: http://lkml.kernel.org/r/20180426103133.GA6953@linaro.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/sched/fair.c